potiuk commented on code in PR #52581:
URL: https://github.com/apache/airflow/pull/52581#discussion_r2176645493
##########
airflow-core/src/airflow/utils/serve_logs.py:
##########
@@ -188,8 +209,13 @@ def serve_logs(port=None):
else:
bind_option = GunicornOption("bind", f"0.0.0.0:{port}")
- options = [bind_option, GunicornOption("workers", 2)]
- StandaloneGunicornApplication(wsgi_app, options).run()
+ # Use Uvicorn worker class for ASGI applications
+ options = [
+ bind_option,
+ GunicornOption("workers", 2),
+ GunicornOption("worker_class", "uvicorn.workers.UvicornWorker"),
+ ]
+ StandaloneGunicornApplication(asgi_app, options).run()
Review Comment:
Not sure what the difference is. But we have to remember that "serve_logs"
is run in "celery" worker - and we do not have "api_server" running there -
serve_log is the only thing that celery workers are exposing. So I think that's
the reason we had "Standalone server". I do not know too much about those.
@pierrejeambrun -> maybe you can help here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
