o-nikolas commented on code in PR #52121:
URL: https://github.com/apache/airflow/pull/52121#discussion_r2164699638
##########
providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor.py:
##########
@@ -97,6 +100,11 @@ class AwsBatchExecutor(BaseExecutor):
# AWS only allows a maximum number of JOBs in the describe_jobs function
DESCRIBE_JOBS_BATCH_SIZE = 99
+ if TYPE_CHECKING and AIRFLOW_V_3_0_PLUS:
+ # In the v3 path, we store workloads, not commands as strings.
+ # TODO: TaskSDK: move this type change into BaseExecutor
+ queued_tasks: dict[TaskInstanceKey, workloads.All] # type:
ignore[assignment]
Review Comment:
There are many of the boiler plate methods that can be moved eventually too
like queuing and processing the workloads. So far most executors just are
copying a default implementation that could live on the base class and those
executors that want to do anything fancy can still override them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
