Lee-W commented on code in PR #46232:
URL: https://github.com/apache/airflow/pull/46232#discussion_r1939189425
##########
airflow/models/dagrun.py:
##########
@@ -1304,8 +1305,14 @@ def verify_integrity(self, *, session: Session =
NEW_SESSION) -> None:
def task_filter(task: Operator) -> bool:
return task.task_id not in task_ids and (
self.run_type == DagRunType.BACKFILL_JOB
- or (task.start_date is None or task.start_date <=
self.logical_date)
- and (task.end_date is None or self.logical_date <=
task.end_date)
+ or (
+ task.start_date is None
+ or (self.logical_date is not None and task.start_date <=
self.logical_date)
+ )
+ and (
+ task.end_date is None
+ or (self.logical_date is not None and self.logical_date <=
task.end_date)
+ )
Review Comment:
```suggestion
or (
task.start_date is None
or self.logical_date is None
or task.start_date <= self.logical_date
)
and (task.end_date is None or self.logical_date is None or
self.logical_date <= task.end_date)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
