Lee-W commented on code in PR #46231:
URL: https://github.com/apache/airflow/pull/46231#discussion_r1938855097
##########
providers/tests/system/microsoft/azure/example_adf_run_pipeline.py:
##########
@@ -22,12 +22,12 @@
from airflow.models import DAG
from airflow.models.xcom_arg import XComArg
+from airflow.providers.microsoft.azure.operators.data_factory import
AzureDataFactoryRunPipelineOperator
+from airflow.providers.microsoft.azure.sensors.data_factory import
AzureDataFactoryPipelineRunStatusSensor
# Ignore missing args provided by default_args
# mypy: disable-error-code="call-arg"
-from airflow.operators.empty import EmptyOperator
-from airflow.providers.microsoft.azure.operators.data_factory import
AzureDataFactoryRunPipelineOperator
-from airflow.providers.microsoft.azure.sensors.data_factory import
AzureDataFactoryPipelineRunStatusSensor
+from airflow.providers.standard.operators.empty import EmptyOperator
Review Comment:
Do we need to make it part of mypy disable?
##########
newsfragments/41368.significant.rst:
##########
@@ -30,10 +30,10 @@ For example, instead of ``from airflow.sensors import
TimeDeltaSensor``, use ``f
* [x] ``airflow.operators.bash_operator.BashOperator`` →
``airflow.operators.bash.BashOperator``
* [x] ``airflow.operators.branch_operator.BaseBranchOperator`` →
``airflow.operators.branch.BaseBranchOperator``
- * [x] ``airflow.operators....EmptyOperator`` →
``airflow.operators.empty.EmptyOperator``
- * [x] ``airflow.operators....DummyOperator`` →
``airflow.operators.empty.EmptyOperator``
- * [x] ``airflow.operators.dummy_operator.EmptyOperator`` →
``airflow.operators.empty.EmptyOperator``
- * [x] ``airflow.operators.dummy_operator.DummyOperator`` →
``airflow.operators.empty.EmptyOperator``
+ * [x] ``airflow.operators....EmptyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
+ * [x] ``airflow.operators....DummyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
+ * [x] ``airflow.operators.dummy_operator.EmptyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
+ * [x] ``airflow.operators.dummy_operator.DummyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
Review Comment:
```suggestion
* [ ] ``airflow.operators....EmptyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
* [ ] ``airflow.operators....DummyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
* [ ] ``airflow.operators.dummy_operator.EmptyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
* [ ] ``airflow.operators.dummy_operator.DummyOperator`` →
``airflow.providers.standard.operators.empty.EmptyOperator``
```
As we'll need to change the rules, let's unmark them so that I won't miss
them
##########
newsfragments/46231.significant.rst:
##########
@@ -0,0 +1,19 @@
+.. Moving EmptyOperator from Airflow core to the ``standard`` provider.
+
+.. EmptyOperator has been moved from Airflow core (``airflow.operators
directory``) to the ``standard`` provider.
+For new and existing DAGs, users must import ``EmptyOperator`` from
``airflow.providers.standard.operators.empty``.
+
+* Types of change
+
+ * [x] Dag changes
+ * [ ] Config changes
+ * [ ] API changes
+ * [ ] CLI changes
+ * [ ] Behaviour changes
+ * [ ] Plugin changes
+ * [ ] Dependency changes
+ * [ ] Code interface changes
+
+.. List the migration rules needed for this change (see
https://github.com/apache/airflow/issues/41641)
+
+* Migration rules needed
Review Comment:
Yep, we'll need migration rules for this one. I think this is `AIR302`. You
can take a look at how other newsfragments are arranged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
