ashb commented on code in PR #43722:
URL: https://github.com/apache/airflow/pull/43722#discussion_r1830232889


##########
airflow/api_fastapi/execution_api/schemas.py:
##########
@@ -112,3 +112,10 @@ def ti_state_discriminator(v: dict[str, str] | BaseModel) 
-> str:
     ],
     Discriminator(ti_state_discriminator),
 ]
+
+
+class TIHeartbeatInfo(BaseModel):
+    """Schema for TaskInstance heartbeat endpoint."""
+
+    hostname: str
+    unixname: str

Review Comment:
   Should we rename this to be more sensible in the protocol? (`username` say?)
   
   I'd also be open to not capturing this at all -- I'm not sure what value it 
adds in keeping it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to