hussein-awala commented on code in PR #36605:
URL: https://github.com/apache/airflow/pull/36605#discussion_r1442320720
##########
airflow/providers/amazon/aws/operators/datasync.py:
##########
@@ -155,12 +155,8 @@ def __init__(
self.allow_random_location_choice = allow_random_location_choice
self.create_task_kwargs = create_task_kwargs or {}
- self.create_source_location_kwargs = {}
- if create_source_location_kwargs:
- self.create_source_location_kwargs = create_source_location_kwargs
- self.create_destination_location_kwargs = {}
- if create_destination_location_kwargs:
- self.create_destination_location_kwargs =
create_destination_location_kwargs
+ self.create_source_location_kwargs = create_source_location_kwargs
+ self.create_destination_location_kwargs =
create_destination_location_kwargs
Review Comment:
```suggestion
self.create_source_location_kwargs = create_source_location_kwargs
or {}
self.create_destination_location_kwargs =
create_destination_location_kwargs or {}
```
##########
airflow/providers/amazon/aws/operators/datasync.py:
##########
@@ -132,8 +132,8 @@ def __init__(
allow_random_task_choice: bool = False,
allow_random_location_choice: bool = False,
create_task_kwargs: dict | None = None,
- create_source_location_kwargs: dict | None = None,
- create_destination_location_kwargs: dict | None = None,
+ create_source_location_kwargs: dict | None = {},
+ create_destination_location_kwargs: dict | None = {},
Review Comment:
```suggestion
create_source_location_kwargs: dict | None = None,
create_destination_location_kwargs: dict | None = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
