bbovenzi commented on code in PR #36522:
URL: https://github.com/apache/airflow/pull/36522#discussion_r1439639467
##########
airflow/www/static/js/dag/details/index.tsx:
##########
@@ -301,7 +302,7 @@ const Details = ({
<TabPanel height="100%">
{isDag && <DagContent />}
{isDagRun && <DagRunContent runId={runId} />}
- {isTaskInstance && (
+ {shouldShowDetailsTab && (
Review Comment:
```suggestion
{!!runId && !!taskId (
```
Let's just do it in a single line since we don't use the variable anywhere
else.
##########
airflow/www/static/js/dag/details/index.tsx:
##########
@@ -301,7 +302,7 @@ const Details = ({
<TabPanel height="100%">
{isDag && <DagContent />}
{isDagRun && <DagRunContent runId={runId} />}
- {isTaskInstance && (
+ {shouldShowDetailsTab && (
Review Comment:
```suggestion
{!!runId && !!taskId && (
```
Let's just do it in a single line since we don't use the variable anywhere
else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
