This is an automated email from the ASF dual-hosted git repository.
amoghdesai pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 78b2d82adf Making changes to priority class (#36365)
78b2d82adf is described below
commit 78b2d82adf778443ac4a6efba0596acf473a70b3
Author: Amogh Desai <[email protected]>
AuthorDate: Wed Dec 27 10:15:01 2023 +0530
Making changes to priority class (#36365)
---
chart/templates/priorityclasses/priority-classes.yaml | 3 ++-
helm_tests/airflow_aux/test_basic_helm_chart.py | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/chart/templates/priorityclasses/priority-classes.yaml
b/chart/templates/priorityclasses/priority-classes.yaml
index cc11ea2d6e..8e82135fb4 100644
--- a/chart/templates/priorityclasses/priority-classes.yaml
+++ b/chart/templates/priorityclasses/priority-classes.yaml
@@ -30,5 +30,6 @@ metadata:
labels:
release: {{ $Global.Release.Name }}
preemptionPolicy: {{ default "PreemptLowerPriority" $e.preemptionPolicy }}
-value: {{ $e.value | required "value is required" }}
+value: {{ $e.value | required "value is required for priority classes" }}
+description: "This priority class will not cause other pods to be preempted."
{{- end }}
diff --git a/helm_tests/airflow_aux/test_basic_helm_chart.py
b/helm_tests/airflow_aux/test_basic_helm_chart.py
index 6413a5361c..0db5936311 100644
--- a/helm_tests/airflow_aux/test_basic_helm_chart.py
+++ b/helm_tests/airflow_aux/test_basic_helm_chart.py
@@ -631,6 +631,7 @@ class TestBaseChartTest:
assert objs[i]["metadata"]["name"] == ("my-release" + "-" +
pc[i]["name"])
assert objs[i]["preemptionPolicy"] == pc[i]["preemptionPolicy"]
assert objs[i]["value"] == pc[i]["value"]
+ assert objs[i]["description"] == "This priority class will not
cause other pods to be preempted."
def test_priority_classes_default_preemption(self):
obj = render_chart(
@@ -644,6 +645,7 @@ class TestBaseChartTest:
)[0]
assert obj["preemptionPolicy"] == "PreemptLowerPriority"
+ assert obj["description"] == "This priority class will not cause other
pods to be preempted."
def test_redis_broker_connection_url(self):
# no nameoverride, redis
