potiuk opened a new pull request, #36243:
URL: https://github.com/apache/airflow/pull/36243
This PR is a response to pretty catastrophic issue caused by expiring key on
MySQL repository on 14th of December. Oracle does not follow the best practices
for signing their packages (while all others do) and their packages and
repositories are signed with a key with short expiry date. This basically puts
an expiry on their repository, and anyone who releases images following best
practices of installation, while keeping the repository after installing mysql
libraries has to rebuild their past released images every 2 years or so.
This is the last straw for our MySQL client installation problems (we had a
few, especially for ARM images) and we decided that we will switch to MariaDB
client libraries by default (while allowing our users to build custom images
with MySQL libraries).
The issue tracked in Airflow repository is
This PR implements a number of changes:
* MariaDB client is now default client used for both ARM and X86
* both pre-2023 and 2023 keys for MySQL are now added to be trusted when
custom image with MySQL client is built
* MySQL repository is removed after installing MySQL (to avoid repeating
similar fiasco for MySQL users in 2025
* changelog added and instructions on how to build custom image with MySQL
client
* one of our test suites is converted to use "current" image not latest
released image (that was bug in our CI).
* test was added in `canary` and `release` builds in CI to also test build
of custom image with MySQL client
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
