pragnareddye commented on code in PR #32414:
URL: https://github.com/apache/airflow/pull/32414#discussion_r1255099997
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1368,10 +1469,17 @@ class
EmrServerlessDeleteApplicationOperator(EmrServerlessStopApplicationOperato
:param wait_for_completion: If true, wait for the Application to be
deleted before returning.
Defaults to True. Note that this operator will always wait for the
application to be STOPPED first.
:param aws_conn_id: AWS connection to use
- :param waiter_countdown: Total amount of time, in seconds, the operator
will wait for each step of first,
- the application to be stopped, and then deleted. Defaults to 25
minutes.
- :param waiter_check_interval_seconds: Number of seconds between polling
the state of the application.
- Defaults to 60 seconds.
+ :param waiter_countdown: (deprecated) Total amount of time, in seconds,
the operator will wait for each
+ step of first,the application to be stopped, and then deleted.
Defaults to 25 minutes.
+ :param waiter_check_interval_seconds: (deprecated) Number of seconds
between polling the state
+ of the application. Defaults to 60 seconds.
+ :waiter_max_attempts: Number of times the waiter should poll the
application to check the state.
+ Default is 25.
+ :param waiter_delay: Number of seconds between polling the state of the
application.
+ Default is 60 seconds.
+ :param deferrable: If True, the operator will wait asynchronously for
application to be deleted.
+ This implies waiting for completion. This mode requires aiobotocore
module to be installed.
+ (default: False)
Review Comment:
Just keeping it consistent with other options
```suggestion
Defaults to False
```
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1368,10 +1469,17 @@ class
EmrServerlessDeleteApplicationOperator(EmrServerlessStopApplicationOperato
:param wait_for_completion: If true, wait for the Application to be
deleted before returning.
Defaults to True. Note that this operator will always wait for the
application to be STOPPED first.
:param aws_conn_id: AWS connection to use
- :param waiter_countdown: Total amount of time, in seconds, the operator
will wait for each step of first,
- the application to be stopped, and then deleted. Defaults to 25
minutes.
- :param waiter_check_interval_seconds: Number of seconds between polling
the state of the application.
- Defaults to 60 seconds.
+ :param waiter_countdown: (deprecated) Total amount of time, in seconds,
the operator will wait for each
+ step of first,the application to be stopped, and then deleted.
Defaults to 25 minutes.
+ :param waiter_check_interval_seconds: (deprecated) Number of seconds
between polling the state
+ of the application. Defaults to 60 seconds.
+ :waiter_max_attempts: Number of times the waiter should poll the
application to check the state.
+ Default is 25.
+ :param waiter_delay: Number of seconds between polling the state of the
application.
+ Default is 60 seconds.
Review Comment:
```suggestion
Defaults to 60 seconds.
```
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1368,10 +1469,17 @@ class
EmrServerlessDeleteApplicationOperator(EmrServerlessStopApplicationOperato
:param wait_for_completion: If true, wait for the Application to be
deleted before returning.
Defaults to True. Note that this operator will always wait for the
application to be STOPPED first.
:param aws_conn_id: AWS connection to use
- :param waiter_countdown: Total amount of time, in seconds, the operator
will wait for each step of first,
- the application to be stopped, and then deleted. Defaults to 25
minutes.
- :param waiter_check_interval_seconds: Number of seconds between polling
the state of the application.
- Defaults to 60 seconds.
+ :param waiter_countdown: (deprecated) Total amount of time, in seconds,
the operator will wait for each
+ step of first,the application to be stopped, and then deleted.
Defaults to 25 minutes.
+ :param waiter_check_interval_seconds: (deprecated) Number of seconds
between polling the state
+ of the application. Defaults to 60 seconds.
+ :waiter_max_attempts: Number of times the waiter should poll the
application to check the state.
+ Default is 25.
Review Comment:
```suggestion
Defaults to 25.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
