potiuk opened a new pull request, #28514:
URL: https://github.com/apache/airflow/pull/28514

   Initially selective check was implemented in the way that it printed 
diagnostic output on stdout and the GITHUB_OUTPUT compatible set of outputs on 
stderr so that it could be redirected to the GITHUB_OUTPUT in its entirety. But 
this turned out to be a bad idea because when there was an error generated in 
selective-checks themselves, the traceback was printed in stderr and 
redirecting stderr to GITHUB_OUTPUT swallowed the traceback.
   
   This change reverses the behaviour:
   
   * diagnostic output is printed to stderr
   * GITHUB_OUTPUT compatible output is printed to stdout
   
   This way when traceback happens it is printed to stderr and is not 
swalleowed by redirection to GITHUB_OUTPUT
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to