This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 6b3bb3c3e9 Change log level to DEBUG when secret not found for google
secret manager (#27856)
6b3bb3c3e9 is described below
commit 6b3bb3c3e9f8a8d3ff33e5c2b09b0491a4bb6481
Author: Ćukasz Wyszomirski <[email protected]>
AuthorDate: Sat Dec 3 17:12:32 2022 +0100
Change log level to DEBUG when secret not found for google secret manager
(#27856)
---
.../providers/google/cloud/_internal_client/secret_manager_client.py | 2 +-
tests/providers/google/cloud/secrets/test_secret_manager.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/airflow/providers/google/cloud/_internal_client/secret_manager_client.py
b/airflow/providers/google/cloud/_internal_client/secret_manager_client.py
index 4a6fe127cc..9ea72e63bb 100644
--- a/airflow/providers/google/cloud/_internal_client/secret_manager_client.py
+++ b/airflow/providers/google/cloud/_internal_client/secret_manager_client.py
@@ -75,7 +75,7 @@ class _SecretManagerClient(LoggingMixin):
value = response.payload.data.decode("UTF-8")
return value
except NotFound:
- self.log.error("Google Cloud API Call Error (NotFound): Secret ID
%s not found.", secret_id)
+ self.log.debug("Google Cloud API Call Error (NotFound): Secret ID
%s not found.", secret_id)
return None
except PermissionDenied:
self.log.error(
diff --git a/tests/providers/google/cloud/secrets/test_secret_manager.py
b/tests/providers/google/cloud/secrets/test_secret_manager.py
index edba0c4cf0..710a575078 100644
--- a/tests/providers/google/cloud/secrets/test_secret_manager.py
+++ b/tests/providers/google/cloud/secrets/test_secret_manager.py
@@ -127,7 +127,7 @@ class TestCloudSecretManagerBackend(TestCase):
secrets_manager_backend =
CloudSecretManagerBackend(connections_prefix=CONNECTIONS_PREFIX)
secret_id = secrets_manager_backend.build_path(CONNECTIONS_PREFIX,
CONN_ID, SEP)
- with self.assertLogs(secrets_manager_backend.client.log,
level="ERROR") as log_output:
+ with self.assertLogs(secrets_manager_backend.client.log,
level="DEBUG") as log_output:
assert secrets_manager_backend.get_conn_uri(conn_id=CONN_ID) is
None
assert secrets_manager_backend.get_connection(conn_id=CONN_ID) is
None
assert re.search(
@@ -202,7 +202,7 @@ class TestCloudSecretManagerBackend(TestCase):
secrets_manager_backend =
CloudSecretManagerBackend(variables_prefix=VARIABLES_PREFIX)
secret_id = secrets_manager_backend.build_path(VARIABLES_PREFIX,
VAR_KEY, SEP)
- with self.assertLogs(secrets_manager_backend.client.log,
level="ERROR") as log_output:
+ with self.assertLogs(secrets_manager_backend.client.log,
level="DEBUG") as log_output:
assert secrets_manager_backend.get_variable(VAR_KEY) is None
assert re.search(
f"Google Cloud API Call Error \\(NotFound\\): Secret ID
{secret_id} not found",