andrewhharmon commented on a change in pull request #5414: [AIRFLOW-4790]
Change dag processing stats to timers
URL: https://github.com/apache/airflow/pull/5414#discussion_r293576654
##########
File path: airflow/utils/dag_processing.py
##########
@@ -984,7 +984,7 @@ def _log_file_processing_stats(self, known_file_paths):
file_name = os.path.basename(file_path)
file_name = os.path.splitext(file_name)[0].replace(os.sep, '.')
if last_runtime:
- Stats.gauge(
+ Stats.timing(
Review comment:
maybe i don't fully understand how the scheduler works and what those
metrics were counting. i think i understand why it's a gauge here. Maybe i need
to add the metric we're interested in in another place. any thoughts? we want
to see a line chart that shows if dag processing is taking a while to help
alert if the scheduler is overwhelmed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
