[ 
https://issues.apache.org/jira/browse/AIRFLOW-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863431#comment-16863431
 ] 

ASF GitHub Bot commented on AIRFLOW-4791:
-----------------------------------------

jgysland commented on pull request #5415: AIRFLOW-4791 add "schema" keyword arg 
to SnowflakeOperator
URL: https://github.com/apache/airflow/pull/5415
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW-4791) issues and references 
them in the PR title.
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   adds `schema` as keyword argument to 
`airflow.contrib.operators.snowflake_operator.SnowflakeOperator`
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   existing tests cover this
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> SnowflakeOperator doesn't support schema argument
> -------------------------------------------------
>
>                 Key: AIRFLOW-4791
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4791
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib, hooks, operators
>    Affects Versions: 1.10.3
>            Reporter: Jake Gysland
>            Priority: Major
>
> {{airflow.contrib.snowflake_operator.SnowflakeOperator}} doesn't provide a 
> way to set the schema to use for the connection.
> There was a [PR opened on 
> [Github|https://github.com/apache/airflow/pull/4306] that added this, but the 
> committer didn't make a Jira ticket or complete the PR message template 
> correctly, and the PR was later closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to