This is an automated email from the ASF dual-hosted git repository.
ddanielr pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/2.1 by this push:
new a56bf9c3dd Raised logging level to debug from trace (#5603)
a56bf9c3dd is described below
commit a56bf9c3dd98cb0d87572b4ce29b5c72a39ee313
Author: Daniel Roberts <ddani...@gmail.com>
AuthorDate: Mon Jun 2 13:30:34 2025 -0400
Raised logging level to debug from trace (#5603)
Moved sized based messages from trace to debug.
Adds new trace message when removing IDs from running cache.
Minor code improvements
---
.../apache/accumulo/coordinator/CompactionCoordinator.java | 13 ++++++++-----
.../apache/accumulo/coordinator/DeadCompactionDetector.java | 6 +++---
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git
a/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java
b/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java
index 59a0dd2782..1b414bd809 100644
---
a/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java
+++
b/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java
@@ -664,16 +664,19 @@ public class CompactionCoordinator extends AbstractServer
implements
// grab the ids that are listed as running in the metadata table. It
important that this is done
// after getting the snapshot.
Set<ExternalCompactionId> idsInMetadata = readExternalCompactionIds();
- LOG.trace("Current ECIDs in metadata: {}", idsInMetadata.size());
- LOG.trace("Current ECIDs in running cache: {}", idsSnapshot.size());
+ LOG.debug("Current ECIDs in metadata: {}", idsInMetadata.size());
+ LOG.debug("Current ECIDs in running cache: {}", idsSnapshot.size());
var idsToRemove = Sets.difference(idsSnapshot, idsInMetadata);
// remove ids that are in the running set but not in the metadata table
- idsToRemove.forEach(ecid -> recordCompletion(ecid));
+ idsToRemove.forEach(this::recordCompletion);
- if (idsToRemove.size() > 0) {
- LOG.debug("Removed stale entries from RUNNING_CACHE : {}", idsToRemove);
+ if (!idsToRemove.isEmpty()) {
+ LOG.debug("Removed {} stale entries from RUNNING_CACHE",
idsToRemove.size());
+ if (LOG.isTraceEnabled()) {
+ idsToRemove.forEach(ecid -> LOG.trace("Removing stale entry: {} from
RUNNING_CACHE", ecid));
+ }
}
}
diff --git
a/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/DeadCompactionDetector.java
b/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/DeadCompactionDetector.java
index 9f123bcda5..3799807f14 100644
---
a/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/DeadCompactionDetector.java
+++
b/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/DeadCompactionDetector.java
@@ -61,7 +61,7 @@ public class DeadCompactionDetector {
// The order of obtaining information is very important to avoid race
conditions.
- log.trace("Starting to look for dead compactions,
deadCompactions.size():{}",
+ log.debug("Starting to look for dead compactions,
deadCompactions.size():{}",
deadCompactions.size());
Map<ExternalCompactionId,KeyExtent> tabletCompactions = new HashMap<>();
@@ -82,7 +82,7 @@ public class DeadCompactionDetector {
return;
}
- log.trace("Read {} tablet compactions into memory from metadata table",
+ log.debug("tabletCompactions.size():{} read into memory from metadata
table",
tabletCompactions.size());
if (log.isTraceEnabled()) {
@@ -137,7 +137,7 @@ public class DeadCompactionDetector {
}
});
- log.trace("deadCompactions.size() after additions {}",
deadCompactions.size());
+ log.debug("deadCompactions.size() after additions {}",
deadCompactions.size());
// Everything left in tabletCompactions is no longer running anywhere and
should be failed.
// Its possible that a compaction committed while going through the steps
above, if so then
