(accumulo) branch main updated: Adds overlooked DoNothingBalancer fallback (#5607)

[kturner]

This is an automated email from the ASF dual-hosted git repository.

kturner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/main by this push:
     new 24acc00dd4 Adds overlooked DoNothingBalancer fallback (#5607)
24acc00dd4 is described below

commit 24acc00dd48c24a59a3aa55a981cf142246d0341
Author: Keith Turner <ktur...@apache.org>
AuthorDate: Mon Jun 2 13:19:48 2025 -0400

    Adds overlooked DoNothingBalancer fallback (#5607)
    
    The DoNothingBalancer was added in 2.1 as a fallback when balancer
    creation fails.  In main there is a new place that creates balancers
    that was not changed when merging the fix forward from 2.1.  Made
    this new place fall back.  Found this because BrokenBalancerIt was
    failing, after this change it passes.
---
 .../server/manager/state/TabletManagementIterator.java     | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git 
a/server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java
 
b/server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java
index fa36ae197c..e542a3a2ea 100644
--- 
a/server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java
+++ 
b/server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java
@@ -51,7 +51,7 @@ import org.apache.accumulo.core.metadata.TabletState;
 import org.apache.accumulo.core.metadata.schema.TabletMetadata;
 import org.apache.accumulo.core.metadata.schema.TabletOperationType;
 import org.apache.accumulo.core.metadata.schema.UnSplittableMetadata;
-import org.apache.accumulo.core.spi.balancer.SimpleLoadBalancer;
+import org.apache.accumulo.core.spi.balancer.DoNothingBalancer;
 import org.apache.accumulo.core.spi.balancer.TabletBalancer;
 import org.apache.accumulo.core.spi.compaction.CompactionKind;
 import org.apache.accumulo.server.compaction.CompactionJobGenerator;
@@ -185,9 +185,15 @@ public class TabletManagementIterator extends 
WholeRowIterator {
     final AccumuloConfiguration conf = new 
ConfigurationCopy(env.getPluginEnv().getConfiguration());
     BalancerEnvironmentImpl benv =
         new BalancerEnvironmentImpl(((TabletIteratorEnvironment) 
env).getServerContext());
-    balancer = Property.createInstanceFromPropertyName(conf, 
Property.MANAGER_TABLET_BALANCER,
-        TabletBalancer.class, new SimpleLoadBalancer());
-    balancer.init(benv);
+    try {
+      balancer = Property.createInstanceFromPropertyName(conf, 
Property.MANAGER_TABLET_BALANCER,
+          TabletBalancer.class, new DoNothingBalancer());
+      balancer.init(benv);
+    } catch (Exception e) {
+      LOG.warn("Failed to create balancer falling back to {}", 
DoNothingBalancer.class, e);
+      balancer = new DoNothingBalancer();
+      balancer.init(benv);
+    }
   }
 
   @Override