This is an automated email from the ASF dual-hosted git repository. ctubbsii pushed a commit to branch 2.1 in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/2.1 by this push: new 18cdc28690 Fix trivial typos and warnings 18cdc28690 is described below commit 18cdc286900b86a0e4699d9ccfff7dc629657aea Author: Christopher Tubbs <ctubb...@apache.org> AuthorDate: Mon Feb 10 17:04:31 2025 -0500 Fix trivial typos and warnings Fix some bad javadocs and warnings about unused items --- core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java | 2 ++ .../src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java | 2 +- .../org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java | 2 ++ .../src/main/java/org/apache/accumulo/server/util/ServiceStatusCmd.java | 1 - .../java/org/apache/accumulo/test/functional/GracefulShutdownIT.java | 1 + 5 files changed, 6 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java b/core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java index 375b5d3b8d..7e332d85fd 100644 --- a/core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java +++ b/core/src/main/java/org/apache/accumulo/core/data/LoadPlan.java @@ -249,6 +249,7 @@ public class LoadPlan { String endRow; RangeType rangeType; + @SuppressWarnings("unused") JsonDestination() {} JsonDestination(Destination destination) { @@ -270,6 +271,7 @@ public class LoadPlan { private static final class JsonAll { List<JsonDestination> destinations; + @SuppressWarnings("unused") JsonAll() {} JsonAll(List<Destination> destinations) { diff --git a/core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java b/core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java index 3df2b10883..c98a2f5c61 100644 --- a/core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java +++ b/core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java @@ -607,7 +607,7 @@ import io.micrometer.core.instrument.MeterRegistry; * <tr> * <td>N/A</td> * <td>N/A</td> - * <td>{@value METRICS_MANAGER_BALANCER_MIGRATIONS_NEEDED}</td> + * <td>{@value #METRICS_MANAGER_BALANCER_MIGRATIONS_NEEDED}</td> * <td>Gauge</td> * <td>The number of migrations that need to complete before the system is balanced</td> * </tr> diff --git a/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java b/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java index e34a8ae297..02e2c5e264 100644 --- a/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java +++ b/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterControl.java @@ -529,6 +529,7 @@ public class MiniAccumuloClusterControl implements ClusterControl { stop(server, hostname); } + @SuppressWarnings("removal") public void refreshProcesses(ServerType type) { switch (type) { case COMPACTION_COORDINATOR: @@ -571,6 +572,7 @@ public class MiniAccumuloClusterControl implements ClusterControl { } } + @SuppressWarnings("removal") public Set<Process> getProcesses(ServerType type) { switch (type) { case COMPACTION_COORDINATOR: diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/ServiceStatusCmd.java b/server/base/src/main/java/org/apache/accumulo/server/util/ServiceStatusCmd.java index 23b0e8aafc..9325231038 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/util/ServiceStatusCmd.java +++ b/server/base/src/main/java/org/apache/accumulo/server/util/ServiceStatusCmd.java @@ -338,7 +338,6 @@ public class ServiceStatusCmd { * Provides explicit method names instead of generic getFirst to get the error count and getSecond * hosts information * - * @param <A> errorCount * @param <B> hosts */ private static class Result<B> extends Pair<Integer,B> { diff --git a/test/src/main/java/org/apache/accumulo/test/functional/GracefulShutdownIT.java b/test/src/main/java/org/apache/accumulo/test/functional/GracefulShutdownIT.java index a638459e56..ad7aef847d 100644 --- a/test/src/main/java/org/apache/accumulo/test/functional/GracefulShutdownIT.java +++ b/test/src/main/java/org/apache/accumulo/test/functional/GracefulShutdownIT.java @@ -249,6 +249,7 @@ public class GracefulShutdownIT extends SharedMiniClusterBase { scanner.setBatchSize(1); int count = 0; for (Entry<Key,Value> e : scanner) { + assertNotNull(e); count++; if (count == 2) { Admin.signalGracefulShutdown(ctx, sserver.toString());