(accumulo) branch 3.1 updated: remove mysterious pass in MetadataConstraints class (#4858)

[kturner]

This is an automated email from the ASF dual-hosted git repository.

kturner pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/3.1 by this push:
     new 38c49b866f remove mysterious pass in MetadataConstraints class (#4858)
38c49b866f is described below

commit 38c49b866f527167b08f902ecc886f6e03229b57
Author: Keith Turner <ktur...@apache.org>
AuthorDate: Mon Sep 9 14:26:45 2024 -0400

    remove mysterious pass in MetadataConstraints class (#4858)
    
    The Metadata constraint was allowing rows that started with `!!~` a free
    pass. AFAIK no code in Accumulo should produce a row with this prefix,
    so removed the code.  I suspect this may be somehow related to previous
    versions of accumulo where the root table was instead a the root tablet
    which was  special tablet in the metadata table.
---
 .../org/apache/accumulo/server/constraints/MetadataConstraints.java    | 3 ---
 1 file changed, 3 deletions(-)

diff --git 
a/server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java
 
b/server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java
index 1b99a5b307..da7acdda64 100644
--- 
a/server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java
+++ 
b/server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java
@@ -162,9 +162,6 @@ public class MetadataConstraints implements Constraint {
     if (row.length > 0 && row[0] == '~') {
       return null;
     }
-    if (row.length > 2 && row[0] == '!' && row[1] == '!' && row[2] == '~') {
-      return null;
-    }
 
     for (byte b : row) {
       if (b == ';') {