This is an automated email from the ASF dual-hosted git repository.
ctubbsii pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/2.1 by this push:
new 6921f79083 Fork compiler in errorprone profile (#3970)
6921f79083 is described below
commit 6921f79083b76675bf9a99e3f914a1b62fb6c302
Author: Christopher Tubbs <ctubb...@apache.org>
AuthorDate: Tue Nov 21 15:38:04 2023 -0500
Fork compiler in errorprone profile (#3970)
Set fork to true in the maven-compiler-plugin's configuration for
the errorprone profile, so that the -J options in the profile
takes effect and the profile works on JDK 16 and later without
creating local configuration for maven toolchains or setting JVM
flags via .mavenrc or .mvn/jvm.config
See https://errorprone.info/docs/installation#maven
Also update the jdk17 profile to jdk16, since that's technically the
first version where the exports are needed.
Also bump errorprone to the latest version
This fixes #3967
---
pom.xml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 12e7379046..27eac387ab 100644
--- a/pom.xml
+++ b/pom.xml
@@ -150,7 +150,7 @@
<version.auto-service>1.1.1</version.auto-service>
<version.bouncycastle>1.76</version.bouncycastle>
<version.curator>5.5.0</version.curator>
- <version.errorprone>2.20.0</version.errorprone>
+ <version.errorprone>2.23.0</version.errorprone>
<version.hadoop>3.3.6</version.hadoop>
<version.opentelemetry>1.27.0</version.opentelemetry>
<version.powermock>2.0.9</version.powermock>
@@ -1665,6 +1665,10 @@
compile time. Auto-generated code is not checked.
See: https://errorprone.info/bugpatterns for list of available bug
patterns.-->
<id>errorprone</id>
+ <properties>
+ <!-- forking is required for -J options to take effect -->
+ <maven.compiler.fork>true</maven.compiler.fork>
+ </properties>
<build>
<plugins>
<plugin>
@@ -1716,9 +1720,9 @@
</build>
</profile>
<profile>
- <id>jdk17</id>
+ <id>jdk16</id>
<activation>
- <jdk>[17,)</jdk>
+ <jdk>[16,)</jdk>
</activation>
<properties>
<extraTestArgs>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens
java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED
--add-opens java.base/java.net=ALL-UNNAMED --add-opens
java.management/java.lang.management=ALL-UNNAMED --add-opens
java.management/sun.management=ALL-UNNAMED --add-opens
java.base/java.security=ALL-UNNAMED --add-opens
java.base/java.lang.reflect=ALL-UNNAMED --add-opens
java.base/java.util.concurrent=ALL-UNNAMED --add-opens java.base/jav [...]
