[accumulo] branch main updated: Improve logging message and comments if tablet overlap occurs. (#2349)

[mmiller]

This is an automated email from the ASF dual-hosted git repository.

mmiller pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/main by this push:
     new a3969c3  Improve logging message and comments if tablet overlap 
occurs. (#2349)
a3969c3 is described below

commit a3969c3f7e6c91e4ae047b27386146ad547f1b12
Author: AlbertWhitlock <albertwhitlo...@gmail.com>
AuthorDate: Wed Nov 24 06:33:35 2021 -0500

    Improve logging message and comments if tablet overlap occurs. (#2349)
---
 .../org/apache/accumulo/tserver/ThriftClientHandler.java    | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git 
a/server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
 
b/server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
index e9b3d3d..dd97375 100644
--- 
a/server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
+++ 
b/server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
@@ -1470,10 +1470,9 @@ public class ThriftClientHandler extends 
ClientServiceHandler implements TabletC
       synchronized (server.openingTablets) {
         synchronized (server.onlineTablets) {
 
-          // checking if this exact tablet is in any of the sets
-          // below is not a strong enough check
-          // when splits and fix splits occurring
-
+          // Checking if the current tablet is in any of the sets
+          // below is not a strong enough check to catch all overlapping 
tablets
+          // when splits and fix splits are occurring
           Set<KeyExtent> unopenedOverlapping =
               KeyExtent.findOverlapping(extent, server.unopenedTablets);
           Set<KeyExtent> openingOverlapping =
@@ -1501,8 +1500,10 @@ public class ThriftClientHandler extends 
ClientServiceHandler implements TabletC
             all.remove(extent);
 
             if (!all.isEmpty()) {
-              log.error("Tablet {} overlaps previously assigned {} {} {}", 
extent,
-                  unopenedOverlapping, openingOverlapping, onlineOverlapping + 
" " + all);
+              log.error(
+                  "Tablet {} overlaps a previously assigned tablet, possibly 
due to a recent split. "
+                      + "Overlapping tablets:  Unopened: {}, Opening: {}, 
Online: {}",
+                  extent, unopenedOverlapping, openingOverlapping, 
onlineOverlapping);
             }
             return;
           }