This is an automated email from the ASF dual-hosted git repository.

jmanno pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git


The following commit(s) were added to refs/heads/main by this push:
     new 7957d67  Set reuseForks to true for unit tests, false for ITs (#2007)
7957d67 is described below

commit 7957d67b0a0d5571a9174660e6353c9cb421e188
Author: Jeffrey Manno <jeffreymann...@gmail.com>
AuthorDate: Fri Apr 9 12:32:11 2021 -0400

    Set reuseForks to true for unit tests, false for ITs (#2007)
    
    * Create surefire and failsafe reuseForks
    * Create a profile to be able to set both values from either false or true
---
 pom.xml | 36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 466f720..8501f39 100644
--- a/pom.xml
+++ b/pom.xml
@@ -126,6 +126,7 @@
     <failsafe.excludedGroups />
     <failsafe.forkCount>1</failsafe.forkCount>
     <failsafe.groups />
+    <failsafe.reuseForks>false</failsafe.reuseForks>
     <hadoop.version>3.3.0</hadoop.version>
     <htrace.hadoop.version>4.1.0-incubating</htrace.hadoop.version>
     <htrace.version>3.2.0-incubating</htrace.version>
@@ -142,14 +143,13 @@
     <!-- timestamp for reproducible outputs, updated on release by the release 
plugin -->
     
<project.build.outputTimestamp>2020-12-17T22:06:50Z</project.build.outputTimestamp>
     <rat.consoleOutput>true</rat.consoleOutput>
-    <!-- surefire/failsafe plugin option -->
-    <reuseForks>false</reuseForks>
     <slf4j.version>1.7.30</slf4j.version>
     
<sourceReleaseAssemblyDescriptor>source-release-tar</sourceReleaseAssemblyDescriptor>
     <surefire.excludedGroups />
     <surefire.failIfNoSpecifiedTests>false</surefire.failIfNoSpecifiedTests>
     <surefire.forkCount>1C</surefire.forkCount>
     <surefire.groups />
+    <surefire.reuseForks>true</surefire.reuseForks>
     <!-- 3.0.0-M5 causes RowHashIT.test and 
ShellServerIT.scansWithClassLoaderContext to fail -->
     <surefire.version>3.0.0-M4</surefire.version>
     <!-- Thrift version -->
@@ -814,7 +814,17 @@
           <artifactId>maven-surefire-plugin</artifactId>
           <configuration>
             <forkCount>${surefire.forkCount}</forkCount>
+            <reuseForks>${surefire.reuseForks}</reuseForks>
             <excludedGroups>${surefire.excludedGroups}</excludedGroups>
+            <!-- Tests to exclude due to not working with reuseForks being 
True -->
+            <excludes>
+              <exclude>**/TableIdTest.java</exclude>
+              <exclude>**/HadoopCredentialProviderTest.java</exclude>
+              <exclude>**/IdleRatioScanPrioritizerTest.java</exclude>
+              <exclude>**/AssignmentWatcherTest.java</exclude>
+              <exclude>**/TestCfCqSlice.java</exclude>
+              <exclude>**/TestCfCqSliceSeekingFilter.java</exclude>
+            </excludes>
             <groups>${surefire.groups}</groups>
             <systemPropertyVariables>
               <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
@@ -827,8 +837,18 @@
           <artifactId>maven-failsafe-plugin</artifactId>
           <configuration>
             <forkCount>${failsafe.forkCount}</forkCount>
+            <reuseForks>${failsafe.reuseForks}</reuseForks>
             <excludedGroups>${failsafe.excludedGroups}</excludedGroups>
             <groups>${failsafe.groups}</groups>
+            <!-- Tests that work excluded above to be included here -->
+            <includes>
+              <include>**/TableIdTest.java</include>
+              <include>**/HadoopCredentialProviderTest.java</include>
+              <include>**/IdleRatioScanPrioritizerTest.java</include>
+              <include>**/AssignmentWatcherTest.java</include>
+              <include>**/TestCfCqSlice.java</include>
+              <include>**/TestCfCqSliceSeekingFilter.java</include>
+            </includes>
             <systemPropertyVariables>
               <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
             </systemPropertyVariables>
@@ -1554,5 +1574,17 @@
         <surefire.forkCount>${forkCount}</surefire.forkCount>
       </properties>
     </profile>
+    <profile>
+      <id>reuseForks</id>
+      <activation>
+        <property>
+          <name>reuseForks</name>
+        </property>
+      </activation>
+      <properties>
+        <failsafe.reuseForks>${reuseForks}</failsafe.reuseForks>
+        <surefire.reuseForks>${reuseForks}</surefire.reuseForks>
+      </properties>
+    </profile>
   </profiles>
 </project>

Reply via email to