Repository: accumulo Updated Branches: refs/heads/master a2d272c6f -> 6cbe886e3
ACCUMULO-1844 Add tests for start classes Ensure the expected classes are available to start's Main class, with the expected keywords, and that there are still corresponding main methods in case somebody executes them directly. Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/6cbe886e Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/6cbe886e Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/6cbe886e Branch: refs/heads/master Commit: 6cbe886e331975a3805921442b10830e025229c2 Parents: 8005e82 Author: Christopher Tubbs <ctubb...@apache.org> Authored: Thu Jan 29 15:04:46 2015 -0500 Committer: Christopher Tubbs <ctubb...@apache.org> Committed: Wed Feb 4 15:14:07 2015 -0500 ---------------------------------------------------------------------- .../apache/accumulo/start/KeywordStartIT.java | 195 +++++++++++++++++++ 1 file changed, 195 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/6cbe886e/test/src/test/java/org/apache/accumulo/start/KeywordStartIT.java ---------------------------------------------------------------------- diff --git a/test/src/test/java/org/apache/accumulo/start/KeywordStartIT.java b/test/src/test/java/org/apache/accumulo/start/KeywordStartIT.java new file mode 100644 index 0000000..b0ea6a4 --- /dev/null +++ b/test/src/test/java/org/apache/accumulo/start/KeywordStartIT.java @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.accumulo.start; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; + +import java.io.IOException; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.util.Arrays; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.TreeMap; + +import org.apache.accumulo.core.file.rfile.PrintInfo; +import org.apache.accumulo.core.util.Classpath; +import org.apache.accumulo.core.util.CreateToken; +import org.apache.accumulo.core.util.Help; +import org.apache.accumulo.core.util.Jar; +import org.apache.accumulo.core.util.Version; +import org.apache.accumulo.gc.GCExecutable; +import org.apache.accumulo.gc.SimpleGarbageCollector; +import org.apache.accumulo.master.Master; +import org.apache.accumulo.master.MasterExecutable; +import org.apache.accumulo.minicluster.MiniAccumuloRunner; +import org.apache.accumulo.minicluster.impl.MiniClusterExecutable; +import org.apache.accumulo.monitor.Monitor; +import org.apache.accumulo.monitor.MonitorExecutable; +import org.apache.accumulo.proxy.Proxy; +import org.apache.accumulo.server.init.Initialize; +import org.apache.accumulo.server.util.Admin; +import org.apache.accumulo.server.util.Info; +import org.apache.accumulo.server.util.LoginProperties; +import org.apache.accumulo.server.util.ZooKeeperMain; +import org.apache.accumulo.shell.Shell; +import org.apache.accumulo.start.spi.KeywordExecutable; +import org.apache.accumulo.tracer.TraceServer; +import org.apache.accumulo.tracer.TracerExecutable; +import org.apache.accumulo.tserver.TServerExecutable; +import org.apache.accumulo.tserver.TabletServer; +import org.apache.log4j.Logger; +import org.junit.Test; + +public class KeywordStartIT { + + private final Logger log = Logger.getLogger(getClass()); + + @Test + public void testKeywordsMatch() throws IOException { + for (Entry<String,KeywordExecutable> entry : Main.getExecutables(getClass().getClassLoader()).entrySet()) { + assertEquals(entry.getKey(), entry.getValue().keyword()); + } + } + + @Test + public void testCheckDuplicates() { + NoOp one = new NoOp("one"); + NoOp anotherOne = new NoOp("another"); + NoOp two = new NoOp("two"); + NoOp three = new NoOp("three"); + List<NoOp> services = Arrays.asList(one, three, two, two, three, three, anotherOne); + assertEquals(7, services.size()); + Map<String,KeywordExecutable> results = Main.checkDuplicates(services); + assertTrue(results.containsKey(one.keyword())); + assertTrue(results.containsKey(anotherOne.keyword())); + assertFalse(results.containsKey(two.keyword())); + assertFalse(results.containsKey(three.keyword())); + assertEquals(2, results.size()); + } + + // Note: this test may fail in Eclipse, if the services files haven't been generated by the AutoService annotation processor + @Test + public void testExpectedClasses() throws IOException { + TreeMap<String,Class<? extends KeywordExecutable>> expectSet = new TreeMap<>(); + expectSet.put("admin", Admin.class); + expectSet.put("classpath", Classpath.class); + expectSet.put("create-token", CreateToken.class); + expectSet.put("gc", GCExecutable.class); + expectSet.put("help", Help.class); + expectSet.put("info", Info.class); + expectSet.put("init", Initialize.class); + expectSet.put("jar", Jar.class); + expectSet.put("login-info", LoginProperties.class); + expectSet.put("master", MasterExecutable.class); + expectSet.put("minicluster", MiniClusterExecutable.class); + expectSet.put("monitor", MonitorExecutable.class); + expectSet.put("proxy", Proxy.class); + expectSet.put("rfile-info", PrintInfo.class); + expectSet.put("shell", Shell.class); + expectSet.put("tracer", TracerExecutable.class); + expectSet.put("tserver", TServerExecutable.class); + expectSet.put("version", Version.class); + expectSet.put("zookeeper", ZooKeeperMain.class); + + Iterator<Entry<String,Class<? extends KeywordExecutable>>> expectIter = expectSet.entrySet().iterator(); + TreeMap<String,KeywordExecutable> actualSet = new TreeMap<>(Main.getExecutables(getClass().getClassLoader())); + Iterator<Entry<String,KeywordExecutable>> actualIter = actualSet.entrySet().iterator(); + Entry<String,Class<? extends KeywordExecutable>> expected; + Entry<String,KeywordExecutable> actual; + while (expectIter.hasNext() && actualIter.hasNext()) { + expected = expectIter.next(); + actual = actualIter.next(); + assertEquals(expected.getKey(), actual.getKey()); + assertEquals(expected.getValue(), actual.getValue().getClass()); + } + boolean moreExpected = expectIter.hasNext(); + if (moreExpected) { + while (expectIter.hasNext()) { + log.warn("Missing class for keyword '" + expectIter.next() + "'"); + } + } + assertFalse("Missing expected classes", moreExpected); + boolean moreActual = actualIter.hasNext(); + if (moreActual) { + while (actualIter.hasNext()) { + log.warn("Extra class found with keyword '" + actualIter.next() + "'"); + } + } + assertFalse("Found additional unexpected classes", moreActual); + } + + @Test + public void checkHasMain() { + assertFalse("Sanity check for test failed. Somehow the test class has a main method", hasMain(this.getClass())); + + HashSet<Class<?>> expectSet = new HashSet<>(); + expectSet.add(Admin.class); + expectSet.add(CreateToken.class); + expectSet.add(Info.class); + expectSet.add(Initialize.class); + expectSet.add(LoginProperties.class); + expectSet.add(Master.class); + expectSet.add(MiniAccumuloRunner.class); + expectSet.add(Monitor.class); + expectSet.add(PrintInfo.class); + expectSet.add(Proxy.class); + expectSet.add(Shell.class); + expectSet.add(SimpleGarbageCollector.class); + expectSet.add(TabletServer.class); + expectSet.add(TraceServer.class); + expectSet.add(ZooKeeperMain.class); + + for (Class<?> c : expectSet) { + assertTrue("Class " + c.getName() + " is missing a main method!", hasMain(c)); + } + + } + + private static boolean hasMain(Class<?> classToCheck) { + Method main; + try { + main = classToCheck.getMethod("main", new String[0].getClass()); + } catch (NoSuchMethodException e) { + return false; + } + return main != null && Modifier.isPublic(main.getModifiers()) && Modifier.isStatic(main.getModifiers()); + } + + private static class NoOp implements KeywordExecutable { + + private final String kw; + + public NoOp(String kw) { + this.kw = kw; + } + + @Override + public String keyword() { + return kw; + } + + @Override + public void execute(String[] args) throws Exception {} + + } +}
