ACCUMULO-378 Remove API method which accepts an instance of ReplicaSystem. There's no reason that a client would commonly have this object instantiated, so it's a bit silly to provide a method that would cater to that case.
Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/aa4746de Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/aa4746de Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/aa4746de Branch: refs/heads/ACCUMULO-378 Commit: aa4746de05b2e2a4ba4ae3dc322fd39ecbac1fda Parents: 24925e1 Author: Josh Elser <els...@apache.org> Authored: Thu Jun 5 16:08:21 2014 -0400 Committer: Josh Elser <els...@apache.org> Committed: Thu Jun 5 16:08:21 2014 -0400 ---------------------------------------------------------------------- .../accumulo/core/client/admin/ReplicationOperations.java | 9 +-------- .../core/client/impl/ReplicationOperationsImpl.java | 8 -------- 2 files changed, 1 insertion(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/aa4746de/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java b/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java index 9267f67..27ef538 100644 --- a/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java +++ b/core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java @@ -32,20 +32,13 @@ import org.apache.accumulo.core.client.replication.ReplicaSystem; public interface ReplicationOperations { /** - * Defines a cluster with the given name using the given {@link ReplicaSystem}. + * Defines a cluster with the given name using the given {@link ReplicaSystem} implementation. * @param name Name of the cluster, used for configuring replication on tables * @param system Type of system to be replicated to */ public void addPeer(String name, Class<? extends ReplicaSystem> system) throws AccumuloException, AccumuloSecurityException, PeerExistsException; /** - * Defines a cluster with the given name using the given {@link ReplicaSystem}. - * @param name Name of the cluster, used for configuring replication on tables - * @param system Type of system to be replicated to - */ - public void addPeer(String name, ReplicaSystem system) throws AccumuloException, AccumuloSecurityException, PeerExistsException; - - /** * Defines a cluster with the given name and the given name system. * @param name Unique name for the cluster * @param replicaType {@link ReplicaSystem} class name to use to replicate the data http://git-wip-us.apache.org/repos/asf/accumulo/blob/aa4746de/core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java b/core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java index 8c50ecc..b16f38f 100644 --- a/core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java +++ b/core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java @@ -85,14 +85,6 @@ public class ReplicationOperationsImpl implements ReplicationOperations { } @Override - public void addPeer(String name, ReplicaSystem system) throws AccumuloException, AccumuloSecurityException, PeerExistsException { - checkNotNull(name); - checkNotNull(system); - - addPeer(name, system.getClass().getName()); - } - - @Override public void addPeer(final String name, final String replicaType) throws AccumuloException, AccumuloSecurityException, PeerExistsException { checkNotNull(name); checkNotNull(replicaType);
