On 12-12-13 1:07 AM, Tina le Grand wrote: > I have reviewed draft-ietf-codec-oggopus-00, and I have some questions > and comments.
Thanks, these are very helpful. > Section 5: > - Would be great if you could mention the name of the two header packets > in the first section. Done. > Section 5.1, list number 4: > - What is a cropped Ogg Opus stream? Did Ron's explaination help? I don't think referencing section 4.4 directly is helpful. What about: "When cropping the beginning of existing Ogg Opus streams, a pre-skip of at least...to ensure complete convergence in the decoder." > Section 5.1, list number 5 (page 13): > - What does this mean "The original sample rate of the encoder input is > not preserved by the lossy compression"? I didn't come up with a way to clarify this without adding three paragraphs, like Ron did. Suggestions? > Section 5.1, list number 5 (page 13): > - There is a new numbered list within list number 5, which makes > the document hard to read. I'll have to think about this one. > - List number 3: Can be more clear: "...decode at the highest supported > rate above the hardware's sample rate and resample." > - Right after the list of 4 ways of choosing decode rate there is a > fifth, that is not in the list. I think it should be merged into the > list as one option. > > Section 5.1.1, page 17: > - Family 1: Would be better if the Vorbis channel order was described in > this spec as well. Agreed. I've added a full description of the channel order for this mapping. > Section 5.2, list number 3: > - NUL -> NULL? or "null" as in section 5.1 list number 2, page 12. This is 'NUL' as in the ascii character code, but 'null-terminated' wins the google fight, so I'll use 'null' in both locations. -r _______________________________________________ codec mailing list [email protected] https://www.ietf.org/mailman/listinfo/codec
