On Mon, Jan 11, 2010 at 3:39 AM, Keyan <m...@pulsschlag.net> wrote:
>> It looks like a couple of the macros don't have the OCAML_ name prefix
>> added to them. For example, COPY_FILE & GET_DEPENDENCIES. You should
>> add the prefix to them as well to prevent name collision when other
>> people use your code.
>
>thanks. wasnt aware of this coding standard, but it makes sense :)
>
>> For the INCLUDES feature, doesn't it just get turned into a list you
>> can iterate on? Couldn't you just use foreach() on it and add the
>> "-I" argument and path argument to a separate list that gets passed to
>> add_custom_command()?
>>
>> foreach(path ${includelist})
>> list(APPEND myargs "-I")
>> list(APPEND myargs "${path}")
>> endforeach()
>
> nice, it worked. my mistake was that i used:
> set(myargs "{$myargs} -I ${path}")
> instead.
>
> i will try to write a FindOcaml.cmake script soon. when i am done, what is
> the best practice to make it available?
Sorry, your email got accidently buried for 3 days. :) Also please
reply to all always so the list gets a copy of the thread.
I think the best way to get it available it to have it released as
part of CMake's Modules folder. To do this you have to volunteer to
maintain the module (basically to deal with patches and bugs) and
follow the process documented in Modules/README.txt to obtain CVS
commit access.
http://public.kitware.com/cgi-bin/viewcvs.cgi/Modules/readme.txt?root=CMake&view=markup
--
Philip Lowman
_______________________________________________
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
