Will do. On Feb 14, 2014, at 11:26 AM, Brad King <[email protected]> wrote:
> On 2/13/2014 7:33 PM, Steve Wilson wrote: >> The topic is visual-studio-preprocessor-undefine. > > Thanks. The method > > cmVisualStudioGeneratorOptions > ::OutputUndefinePreprocessorDefinitions > > appears to duplicate a lot of code from > > cmVisualStudioGeneratorOptions > ::OutputPreprocessorDefinitions > > Please factor out and parameterize the common pieces to > avoid the duplication. > > Also, the test case appears to undef a macro in a specific > source file and test that it is undefined, but never defines > the macro for the whole target so of course it will never > be defined and the test will always pass. > > Thanks, > -Brad > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
signature.asc
Description: Message signed with OpenPGP using GPGMail
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
