Steve,

In these hunks:

-  if(this->GetType() == cmTarget::STATIC_LIBRARY)
+  if(this->LinkLanguageDependsOnLinkImplementation())
...
+  bool LinkLanguageDependsOnLinkImplementation() const
+  { return this->TargetTypeValue == STATIC_LIBRARY; }

The description of the test as "link language depends
on link implementation" is not correct.  The blocks
guarded by this test are about setting the interface
link languages of a static library to propagate to
dependents, not the link language of the target itself.
Perhaps

  bool LinkLanguagePropagatesToDependents() const
  { return this->TargetTypeValue == STATIC_LIBRARY; }

or

  bool LinkLanguageInInterface() const
  { return this->TargetTypeValue == STATIC_LIBRARY; }

is better?  Other ideas for a better name?

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to