On Tue, 31 Mar 2026 22:27:00 GMT, Ashay Rane <[email protected]> wrote:
> Prior to this patch, both the build and the tests included several > references to C:/. References in the build assumed that Windows is > installed on C:/, which causes the build to fail when Windows is > installed on a different drive. The references among tests assumed that > the C:/ drive exists, which although mostly correct, is not guaranteed, > making the tests fragile. > > This patch fixes the build references using the path derived from that > to cmd.exe, which itself is discovered from the PATH environment > variable. We deliberately avoid using `SYSTEMROOT` and related > variables since these are not set on WSL2. This patch also updates the > test to not use the presence of C:/ to detect Windows. Instead, the > test now probes the `java -XshowSettings:all` output to know whether the > test is running on Windows. This pull request has now been integrated. Changeset: e7969288 Author: Ashay Rane <[email protected]> Committer: Erik Joelsson <[email protected]> URL: https://git.openjdk.org/jdk/commit/e79692881fab1d4c986b72a08f73bfc1b19f39b7 Stats: 20 lines in 3 files changed: 11 ins; 0 del; 9 mod 8381449: Build fails when Windows is not installed on C: Reviewed-by: ysuenaga, erikj, lmesnik ------------- PR: https://git.openjdk.org/jdk/pull/30523
