On Fri, 30 Dec 2022 06:53:56 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> There's a more compact way of doing this: > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m > line 605: > >> 603: DECLARE_STATIC_METHOD(jm_getAccessibleActionCount, >> sjc_CAccessibility, "getAccessibleActionCount", >> "(Ljavax/accessibility/AccessibleAction;Ljava/awt/Component;)I"); >> 604: jint count = (*env)->CallStaticIntMethod(env, >> sjc_CAccessibility, jm_getAccessibleActionCount, axAction, fComponent); >> 605: CHECK_EXCEPTION(); > > Do we need to call "(*env)->DeleteLocalRef(env, axAction);" in case of error > in CHECK_EXCEPTION? I think we still reach the DeleteLocalRef that's further down at line 624 ------------- PR: https://git.openjdk.org/jdk/pull/11803
