> On Dec 7, 2022, at 3:41 AM, Thomas Stuefe <[email protected]> wrote:
> 
>  am surprised this even builds.

It builds for me…

* Toolchain:      clang (clang/LLVM from Xcode 14.1)

With the exception of these errors in cmstypes.c

/Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132:
 error: parameter 'SizeOfTag' set but not used 
[-Werror,-Wunused-but-set-parameter]
void *Type_ProfileSequenceId_Read(struct _cms_typehandler_struct* self, 
cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)
                                                                                
                                                   ^
/Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:5137:125:
 error: parameter 'SizeOfTag' set but not used 
[-Werror,-Wunused-but-set-parameter]
void *Type_Dictionary_Read(struct _cms_typehandler_struct* self, cmsIOHANDLER* 
io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)
                                                                                
                                            ^
2 errors generated.

I had seen this sometime back. The same workaround of adding…

cmsUNUSED_PARAMETER(SizeOfTag);    // mjh

To the two methods, which I had noticed included elsewhere in the code, still 
appears to work.

I first noticed the sprintf issue in later releases of Xcode 13. It isn’t just 
Xcode 14.

Reply via email to