On Wed, 16 Nov 2022 05:37:19 GMT, Jayathirth D V <[email protected]> wrote:

>> This test was failing because of color difference on boundaries. Updated 
>> test case to not check edges and added color tolerance.
>> 
>> Also updated test to:
>> 1) Use standard GraphicsConfiguration bounds for image instead of constant 
>> numbers.
>> 2) Use waitForIdle before screen capture and added auto delay
>> 3) Move mouse pointer away from rendering content (In my local Mac it failed 
>> every time when mouse pointer was present over test frame)
>> 4) Remove usage of insets as it is undecorated and remove windows closing 
>> listener
>> 5) Dispose frame when test fails
>> 
>> With these changes test is not failing in CI with multiple runs on all 
>> platforms.
>
> Jayathirth D V has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove comment

test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
 line 89:

> 87: 
> 88:         final Frame frame = new Frame("OnScreenRenderingResizeTest") {
> 89:             public void paint(Graphics g) {}

Looks like these two empty methods are removed by the fix, why?

-------------

PR: https://git.openjdk.org/jdk/pull/11158

Reply via email to