On Tue, 15 Nov 2022 00:21:23 GMT, Alexander Zvegintsev <[email protected]> 
wrote:

> This test was problem listed with ["some tests that leave windows open on the 
> desktop" 
> reason](https://github.com/openjdk/jdk/commit/fd8df3adf13f5df8f5f95482b8e0a70bc519f39f)
> 
> The main issue with the test is that it may pass, but in fact the actual test 
> was not even performed. <br>`jtreg` kills the test window after exiting main 
> and ends the test before it double clicks on window's title(actual test 
> starts from `windowActivated` event).
> 
> So the test was refactored and stabilized:
> * robot invocation moved from EDT to main thread.
> * throwing test exception is performed only after frame is disposed
> * extra delay added after showing window.
> 
> Old Ubuntu 16.04 and macOS 10.10.5 failures is no longer reproducible on 
> modern systems.
> 
> CI testing looks good.

test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.java line 117:

> 115:     public void mouseClicked(MouseEvent e) {fail(e);}
> 116: 
> 117:     public void windowActivated(WindowEvent  e) {}

nit
Suggestion:

    public void windowActivated(WindowEvent e) {}

-------------

PR: https://git.openjdk.org/jdk/pull/11150

Reply via email to