On Wed, 16 Nov 2022 05:37:15 GMT, Alexander Zuev <[email protected]> wrote:

>> On m1 mac sometimes (in very rare instance) it takes a long time to get the 
>> sequencer so increasing timeout helps with that.
>> Also on m1 mac sequencer got notified about the first MetaMessage twice. The 
>> reason is unclear but watching for that fixes the problem. Also on Linux 
>> sometimes process hangs indefinitely without finishing hold by the 
>> com.sun.media.sound.MediaDispatcher. Closing the sequencer at the end of the 
>> test helps with that.
>
> Alexander Zuev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fixed typo in copyright year

test/jdk/javax/sound/midi/Sequencer/MetaCallback.java line 119:

> 117:             finished = true;
> 118:         } else if (msg.getData().length > 0 && msg.getType() == 1 && 
> !received.contains(msg)) {
> 119:             received.add(msg);

Do we not need to do seq.stop() before close() in l136

-------------

PR: https://git.openjdk.org/jdk/pull/11157

Reply via email to