On Mon, 14 Nov 2022 01:51:32 GMT, David Holmes <[email protected]> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - use os::snprintf for desktop update >> - use os::snprintf > > src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp line > 638: > >> 636: return; >> 637: } >> 638: os::snprintf(channelName, 16, "Ch %d", ch); > > You can't use this here - this is not hotspot code! You are right. Reverted to use `snprintf` for desktop update. Thanks! ------------- PR: https://git.openjdk.org/jdk/pull/11115
