On 7/25/2022 6:32 AM, Martin Desruisseaux wrote:
Le 25/07/2022 à 14:20, Kevin Rushforth a écrit :
(…snip…) You can file a bug against "Client Libraries" / "2d" at
https://bugreport.java.com/ (or find a sponsor on this list who is
willing to file it for you), and then change the title of your PR to
include that bug ID in the title.
I was not aware of this link, I thought that only OpenJDK committers
could fill bug reports. Thanks for the link, this is done and got
internal review ID : 9073683.
You're welcome. Btw, you can't use this ID in your PR, since the
internal ID is transient. Once it is transferred to the JDK project in
JBS it will get a permanent ID that you can use.
Once your PR is RFR, you can expect that there will be some
discussion on it, since you propose to change the implementation of
equals, rather than limiting your change to the implementation of
hashCode.
Yes this is expected. Note that change to equals method can not be
avoided since current implementation is inconsistent with itself
(A.equals(A) can return false). About how to make equals consistent
with hashCode, as said previously there is at least 2 possible ways of
doing that.
This can be discussed during the review.
-- Kevin
Martin
