Re: [cp-patches] FYI Only truncate a file on append and write-only (from FileOutputStream)

[Andrew Haley]

Mark Wielaard writes:
 > Hi,
 > 
 > This fixes a bug reported by Steve Blackburn. Mauve tests have been
 > added.
 > 
 > 2007-05-30  Mark Wielaard  <[EMAIL PROTECTED]>
 > 
 >     Fixes bug #32030 reported by [EMAIL PROTECTED]
 >     * native/jni/java-nio/gnu_java_nio_VMChannel.c
 >     (Java_gnu_java_nio_VMChannel_open): Only set O_TRUNC on CPNIO_APPEND
 >     and O_WRONLY.

Uh, no.  You don't want to set O_TRUNC on CPNIO_APPEND.  And you
don't, either:

 > diff -u -r1.18 gnu_java_nio_VMChannel.c
 > --- native/jni/java-nio/gnu_java_nio_VMChannel.c        24 May 2007 22:15:21 
 > -0000      1.18
 > +++ native/jni/java-nio/gnu_java_nio_VMChannel.c        30 May 2007 09:49:50 
 > -0000
 > @@ -1676,7 +1676,7 @@
 >    nmode = (nmode
 >             | ((nmode == O_RDWR || nmode == O_WRONLY) ? O_CREAT : 0)
 >             | ((mode & CPNIO_APPEND) ? O_APPEND :
 > -              ((nmode == O_RDWR || nmode == O_WRONLY) ? O_TRUNC : 0))
 > +              ((nmode == O_WRONLY) ? O_TRUNC : 0))
 >             | ((mode & CPNIO_EXCL) ? O_EXCL : 0)
 >             | ((mode & CPNIO_SYNC) ? O_SYNC : 0));

Andrew.