Keith Seitz wrote:
Kyle Galloway wrote:
Comments, concerns, or is this ok to commit?

Ok, but please double-check the indentation before you commit. It may just be my mailer, but the String-based constructor looks mis-indented.
I have committed this. The indentation was mangled, but in a different way then the mailer mangled it. I fixed it, and I also went back and fixed the indentation on two of my patches from yesterday that got mangled somewhere along the line. I think my VIM settings may be causing problems, I'll look into it.

Thanks,
Kyle

Reply via email to