Hi Olivier,

On Mon, 2006-02-20 at 14:23 +0100, Olivier Jolly wrote:
> First I wanted to implement it with a contains, but unfortunately, 
> contains relies on equals, which will check that the declaring class are 
> the same before saying that two methods are equals. In this case, we 
> know we have the same methods expected that the declaring class are 
> differents, that's the whole point of the fix [...]

Doh. Right. So much for the insightful peer review...

Please do add a little comment for the isCoreObjectMethod() method
saying this. Just for people like me that might want to be clever and
update the code to be more efficient. Although your new Mauve patches
will now catch them if they try this :)

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to