Not that you're missing anything, but... You can't overload C++ methods by return value. Thus, you can't just make a string16 version of "std::wstring TreeNode::GetTitle()", the call used to return a bookmark title. So you'll probably have to change a bunch of call sites as part of your "add overloads" step.
On the Mac (chrome/browser/cocoa/bookmark*.mm), calls into the bookmark model which return wstring are almost always wrapped with a base::SysWideToNSString(). If you change the return value to string16, the new wrap is base::SysUTF16ToNSString(). jrg On Tue, Jan 5, 2010 at 1:00 PM, Munjal Doshi <[email protected]> wrote: > I wanted to send out the plan to move bookmark model to string16 to > everyone since bookmark model interface is consumed in many places: > > > 1. Change the internal data model to use string16. > 2. Add string16 overloads for various methods that currently use > wstring. > 3. Change all the callsites incrementally to use string16 overloads. > 4. Remove wstring methods. > > I plan to do this in Jan. Please let me know if I am missing something > here. > > -Munjal > > > -- > Chromium Developers mailing list: [email protected] > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev >
-- Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
