On Tue, Dec 1, 2009 at 2:30 PM, oshima <[email protected]> wrote: > Looks like there are more tests that failing in valgrind test. > > shard=1 id=1513 > [ FAILED ] WorkerTest.MultipleWorkers (103254 ms) > [ FAILED ] NewTabUITest.ChromeInternalLoadsNTP (74002 ms) > [ FAILED ] ChromeMainTest.AppLaunch (36539 ms) > shard=2 id=1916 > [ FAILED ] WorkerTest.IncognitoSharedWorkers (181154 ms) > [ FAILED ] SessionHistoryTest.FLAKY_LocationReplace (48297 ms) > shard=3 id=1761 > [ FAILED ] WorkerTest.SharedWorkerFastLayoutTests (731911 ms) > [ FAILED ] AutomationProxyTest.NavigateToURLWithTimeout1 (42516 ms) > shard=4 id=2075 > [ FAILED ] WorkerTest.WorkerHttpLayoutTests (119981 ms) > [ FAILED ] AutomationProxyTest.NavigateToURLWithTimeout2 (36359 ms) > [ FAILED ] UnloadTest.CrossSiteInfiniteBeforeUnloadSync (342050 ms) > [ FAILED ] MetricsServiceTest.CrashRenderers (49324 ms) > > This is not good. Is there any issue if we make a valgrind test fail when > the test itself fails? > If not, I'd suggest that we exclude them in ui_tetsts.gtext.txt for now > (I'll file bugs) > and change the test script so that a valgrind test fails when the test > itself tails. > Any opinion? > > My quick read of this makes it sounds like you're planning to disable various tests (like WorkerTests which can easily get broken due to webkit changes) so that *they don't run at all* simply because valgrind can't seem to run it. Please don't do that.
If you're going to do changes to scripts and such, maybe you can change it so that valgrind has some additional skip list. Thanks, Dave - oshima > On Fri, Nov 20, 2009 at 12:25 PM, Mitsuru Oshima <[email protected]>wrote: > >> Hi, >> >> I noticed, while working on enabling valgrind test on linux/views, that >> some of WorkerTest of ui tests in Linux Tests (valgrind) buildbot >> are failing due to mmap failure.I tested locally with valgrind I >> built using the script under tools/valgrind (with regular ld, but not gold), >> and I got the same/similar mmap errors. I did quick search on bug db, but >> couldn't find it. I'm going to file a bug, but does anyone know about this >> problem? >> >> - oshima >> >> [==========] Running 37 tests from 23 test cases. >> [----------] Global test environment set-up. >> [----------] 2 tests from WorkerTest >> [ RUN ] WorkerTest.SingleWorker >> [8072:8072:1120/090807:5253075177881:INFO:/b/slave/chromium-rel-linux-valgrind-builder/build/src/chrome/test/ui/ui_test.cc(1126)] >> BROWSER_WRAPPER was set, prefixing command_line with >> /b/slave/chromium-rel-linux-valgrind-tests-1/build/valgrind.tmp/browser_wrapper.ohLiPE >> valgrind: mmap(0x38000000, 1871872) failed in UME with error 22 (Invalid >> argument). >> valgrind: this can be caused by executables with very large text, data or >> bss segments. >> /b/slave/chromium-rel-linux-valgrind-builder/build/src/chrome/worker/worker_uitest.cc:28: >> Failure >> Value of: value.c_str() >> Actual: "" >> Expected: kTestCompleteSuccess >> Which is: "OK" >> [8078:8078:5253178758444:ERROR:/b/slave/chromium-rel-linux-valgrind-builder/build/src/chrome/browser/automation/automation_provider.cc(957)] >> AutomationProxy went away, shutting down app. >> [ FAILED ] WorkerTest.SingleWorker (109607 ms) >> > > -- > Chromium Developers mailing list: [email protected] > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev > -- Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
