EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
Otherwise, I'm quite happy with this patch. The only downside I see is if `testComparisons6` fails, it will report the source of the failure as being in the header, and not provide information about the callee. But I think having simpler tests to read and write is more important. Hopefully they shouldn't be falling too often anyway :-P https://reviews.llvm.org/D49773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
