ahatanak added inline comments.
================
Comment at: lib/CodeGen/CGBlocks.cpp:1905
+    case BlockCaptureEntityKind::None:
+      llvm_unreachable("unexpected BlockCaptureEntityKind");
     }
----------------
rjmccall wrote:
> These two switches differ only in (1) what kind of cleanup they push and (2) 
> a small optimization that can easily be conditionalized by the request to 
> push an EH-only cleanup.
Merged the two switch statements into helper function pushCaptureCleanup.


Repository:
  rC Clang

https://reviews.llvm.org/D49718



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to