probinson added a comment. Re. SmallVector versus std::vector, they are functionally similar but have different memory-allocation behaviors. SmallVector includes a vector of N elements (where N is the template parameter) so does no dynamic allocation until you have more than N elements; but it takes up that much more space as a member of a class. It's mainly intended for stack variables. Given that this particular option is used rarely, I would probably go with std::vector. The code change otherwise is pretty simple and looks fine.
As for testing, it has its quirks for sure. But I'm happy to help sort out any issues. There should be plenty of CodeGen examples with debug info in the test tree to imitate. You'll want to start with C/C++ source and use `-emit-llvm` to get textual IR, then use FileCheck (our fancy-pants grep) to look for the new pathname patterns. Repository: rC Clang https://reviews.llvm.org/D49652 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
