ldionne added a comment.

This change LGTM. However, I do have a question about the overall change 
(including r335809 and r337118). Why is it that we're not simply relying on the 
`CMAKE_INSTALL_PREFIX` being set to the path where we should install instead of 
using all these custom variables  like `LIBCXX_INSTALL_HEADER_PREFIX`? I'm 
curious to understand what's special about your use case, since it does seem 
like we're doing things differently in a few places for Fuchsia.


Repository:
  rCXX libc++

https://reviews.llvm.org/D49584



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to