erichkeane added inline comments.
================
Comment at: include/clang/Basic/Attr.td:851
+ let Spellings = [Clang<"cpu_specific">];
+ let Args = [VariadicIdentifierArgument<"Cpus">];
+ let Subjects = SubjectList<[Function]>;
----------------
aaron.ballman wrote:
> erichkeane wrote:
> > aaron.ballman wrote:
> > > `Cpus` -> `CPUs` ?
> > So, I agree with you we should be consistent with spelling. However, in
> > this case, I'd prefer not changing this one. This is what the generated
> > code in Attrs.inc looks like if I change it:
> >
> > typedef IdentifierInfo ** cPUs_iterator;
> > cPUs_iterator cPUs_begin() const { return cPUs_; }
> > cPUs_iterator cPUs_end() const { return cPUs_ + cPUs_Size; }
> > unsigned cPUs_size() const { return cPUs_Size; }
> > llvm::iterator_range<cPUs_iterator> cPUs() const { return
> > llvm::make_range(cPUs_begin(), cPUs_end()); }
> >
> > I think having "Cpus" in 2 places is way better than having to spell it as
> > cPUs_begin. Your thoughts?
> Oh wow that is disgusting. Yes, please leave as `Cpus` here.
:-D Already Done!
https://reviews.llvm.org/D47474
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
