hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clangd/JSONRPCDispatcher.cpp:138 }); + auto ID = 1; + log("--> {0}({1})", Method, ID); ---------------- nit I'd suggest putting this statement immediately after the above `FIXME`, it took me a while to understand why it is `1`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49224 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits