smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM, particularly given r314138.
There are other umbrella libraries as well, e.g. OneCore and OneCoreUAP. Do you
care about those as well or just WindowsApp?
================
Comment at: lib/Driver/ToolChains/MinGW.cpp:207
+ if (Lib == "windowsapp")
+ HasWindowsApp = true;
+
----------------
I don't think it matters very much, but you could break out here.
================
Comment at: lib/Driver/ToolChains/MinGW.cpp:232
+ if (!HasWindowsApp) {
+ // add system libraries
+ if (Args.hasArg(options::OPT_mwindows)) {
----------------
Might be worth adding a short note to this comment about why we skip adding
these libraries in the WindowsApp case?
Repository:
rC Clang
https://reviews.llvm.org/D49059
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
