QF5690 added inline comments.
================
Comment at: lib/Sema/SemaObjCProperty.cpp:2554
+ PropertyTy->isObjCRetainableType() &&
+ !PropertyTy->isObjCClassType()) {
+ Diag(Loc, diag::warn_objc_property_assign_on_object);
----------------
rjmccall wrote:
> Please use `isObjCARCImplicitlyUnretainedType` here.
Thanks, didn't notice it.
================
Comment at: test/SemaObjC/property-in-class-extension-1.m:18
-@property (assign, readonly) NSString* changeMemoryModel; // expected-note
{{property declared here}}
+@property (unsafe_unretained, readonly) NSString* changeMemoryModel; //
expected-note {{property declared here}}
----------------
rjmccall wrote:
> Whoa, why is this test case using `-Weverything`? That seems unnecessarily
> fragile.
Do you think it should be relaxed only to warnings that are appearing here?
Repository:
rC Clang
https://reviews.llvm.org/D44539
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
