hokein added a comment. still LGTM.
The diff contains unrelated changes now. ================ Comment at: clangd/tool/ClangdMain.cpp:104 + llvm::cl::values(clEnumVal(Logger::Error, "Error messages only"), + clEnumVal(Logger::Info, "High level execution tracing"), + clEnumVal(Logger::Debug, "Low level details")), ---------------- sammccall wrote: > hokein wrote: > > Is it intended not to expose `Verbose` mode? > dlog is already controlled by -debug/-debug-only flag, so it seems it doesn't > need a distinct level here too. WDYT? > > Renamed flag value to "verbose". Yeah, vlog is controlled by debug flag. A flag "verbose" is more natural than `debug`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49008 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
