ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a minor NIT
================
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:88
+ (CI.getDiagnosticClient().getNumErrors() > 0)) {
+ llvm::errs() << "Found errors in the translation unit. Igoring "
+ "collected symbols...\n";
----------------
NIT: Maybe use clangd's `log` here? To get timestamps in the output, etc.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48881
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
